Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark SystemThemeHelper methods as obsolete #1324

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

morning4coffe-dev
Copy link
Member

GitHub Issue (If applicable): part of unoplatform/uno#19235

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1324.eastus2.azurestaticapps.net

Copy link
Contributor

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morning4coffe-dev I believe we actually don't have docs right now for SystemThemeHelper. We should add it, probably better to be in a separate PR

src/Uno.Toolkit.UI/Helpers/SystemThemeHelper.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Helpers/SystemThemeHelper.cs Outdated Show resolved Hide resolved
@morning4coffe-dev morning4coffe-dev changed the title chore: Hide SystemThemeHelper methods from IntelliSense chore: Mark SystemThemeHelper methods as obsolete Jan 27, 2025
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1324.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1324.eastus2.azurestaticapps.net

@MartinZikmund MartinZikmund merged commit 06822e9 into main Jan 31, 2025
28 checks passed
@MartinZikmund MartinZikmund deleted the dev/doti/hide-systemthemehelper-methods branch January 31, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants